Fix treatment of no-output ERB tags #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlfan
reviewed
Apr 10, 2025
Comment on lines
+90
to
+99
| function wrapInEslintDisable(text) { | ||
| return `/* eslint-disable */${text}/* eslint-enable */`; | ||
| } | ||
| return preprocess(text, filename, dummyString); | ||
|
|
||
| function toDummyString(id, matchText) { | ||
| if (matchText.startsWith("<%=")) { | ||
| return wrapInEslintDisable(`{}/* eslint-plugin-erb ${HASH} ${id} */`); | ||
| } | ||
| return wrapInEslintDisable(`/* eslint-plugin-erb ${HASH} ${id} */`); | ||
| } |
There was a problem hiding this comment.
I'm just gonna leave this idea here, I don't feel like forking this repo today:
Suggested change
| function wrapInEslintDisable(text) { | |
| return `/* eslint-disable */${text}/* eslint-enable */`; | |
| } | |
| return preprocess(text, filename, dummyString); | |
| function toDummyString(id, matchText) { | |
| if (matchText.startsWith("<%=")) { | |
| return wrapInEslintDisable(`{}/* eslint-plugin-erb ${HASH} ${id} */`); | |
| } | |
| return wrapInEslintDisable(`/* eslint-plugin-erb ${HASH} ${id} */`); | |
| } | |
| function toDummyString(id, matchText) { | |
| let replacement = ""; | |
| if (matchText.startsWith("<%=")) replacement = "{}"; | |
| const tagged = `${replacement}/* eslint-plugin-erb ${HASH} ${id} */`; | |
| const wrapped = `/* eslint-disable */${tagged}/* eslint-enable */`; | |
| return wrapped; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15. We now use the replacement to
{}only if the ERB tag starts with<%=. For all other tags (including<%and<%#), we replace them by a simple comment, without any actual remaining JS-syntax (i.e. no{}).A respective test was added.